#22OPEN Pull Request
Update Scan store to ingest `GovernanceLock`s and `VestingLock`s
mrdziuban04-09-2026Last activity 1d ago
Fixes canton-network/splice#7124
This updates ScanStore.contractFilter to add filters for GovernanceLocks and VestingLocks to ensure they're ingested.
Note that CI failures are expected -- DbScanStoreTest won't pass on the locking/m1 branch without updating the DAR files and regenerating DarResources.scala. After I took the following steps locally, the tests pass.
sbt damlBuild- Manually copied changing DAR files from
.daml/distdirectories to committed versions indaml/dars sbt updateDarResourcesto regenerateDarResources.scala
Pull Request Checklist
Cluster Testing
- If a cluster test is required, comment
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it. - If an upgrade test is required, comment
/upgrade_teston this PR to request it, and ping someone with access to the DA-internal system to approve it. - If a hard-migration test is required (from the latest release), comment
/hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it. - If a logical synchronizer upgrade test is required (from canton-3.5), comment
/lsu_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.
PR Guidelines
- Include any change that might be observable by our partners or affect their deployment in the release notes.
- Specify fixed issues with
Fixes #n, and mention issues worked on using#n - Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool
Merge Guidelines
- Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).