Skip to content
CCPEDIAby Unity Nodes
Discussions/App Development/No Ord instance for NonEmptyForum ↗

No Ord instance for NonEmpty

App Development5 posts295 views11 likesLast activity Aug 2021
HU
huwOP
Aug 2021

Hi there, it seems that NonEmpty does not have an Ord instance. Any plans to add this? Would be nice to have. I realize now that I can make PRs onto Daml’s public Github repo, happy to make a PR for this one, should be fairly straightforward to add I think.

CO
cocreature
Aug 2021

Hi @huw, an Ord instance for NonEmpty would definitely me reasonable and we’d happily accept a PR!

HU
huw
Aug 2021

Great! I’ll give it a shot

HU
huw
Aug 2021

Hi @cocreature , I have created the code and tests for this change. Seems I get a 403 error trying to push to a branch on your repo. Do I need to request access?

CO
cocreature
Aug 2021

You can create a pull request from a fork. First fork the repository, then push to a branch on your fork and then create a PR from that. See Creating a pull request from a fork - GitHub Docs for details.

← Back to Discussions