Skip to content
CCPEDIAby Unity Nodes
#7888CLOSED Pull Request

Sloppy PoC, don't merge: Add failing test: validator unvets packages of a scheduled upgrade on restart

martinflorian-da21-10-2026

Reproduces bug in unvetting logic: we unvet packages that are scheduled to come into effect but the vote is not effective yet, defeating the purpose of early pre-vetting.

This is vibe coded, please don't just use it without reflection.

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If an upgrade test is required, comment /upgrade_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a logical synchronizer upgrade test is required (from canton-3.5), comment /lsu_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).
← Back to Proposals