#7894OPEN Pull Request
Fix protocol version check in staticSynchronizerParameters
moritzkiefer-da21-10-2026
The 37 was buggy, we accidentally changed that as part of a replacement from 36 to 37. The more important part is that the protocol version is taken from the successor synchronizer id which is the part that has blown up on 36.
I can't write a test for this as we don't support PV 35 anymore so I can't make the if condition fail.
I also want to fully remove the local protocol version config but I'll do that in a follow up. And as part of that probably also just remove the protocolVersion >= v36 condition as it's redundant on main.
[ci]
Pull Request Checklist
Cluster Testing
- If a cluster test is required, comment
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it. - If an upgrade test is required, comment
/upgrade_teston this PR to request it, and ping someone with access to the DA-internal system to approve it. - If a hard-migration test is required (from the latest release), comment
/hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it. - If a logical synchronizer upgrade test is required (from canton-3.5), comment
/lsu_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.
PR Guidelines
- Include any change that might be observable by our partners or affect their deployment in the release notes.
- Specify fixed issues with
Fixes #n, and mention issues worked on using#n - Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool
Merge Guidelines
- Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).